-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jmeter take 3 #2284
Merged
Merged
Jmeter take 3 #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motorina0
force-pushed
the
jmter_take_3
branch
from
February 20, 2024 12:40
7d7c2d3
to
b161923
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2284 +/- ##
=======================================
Coverage 58.54% 58.54%
=======================================
Files 61 61
Lines 9185 9185
=======================================
Hits 5377 5377
Misses 3808 3808 ☔ View full report in Codecov by Sentry. |
motorina0
force-pushed
the
jmter_take_3
branch
from
February 28, 2024 14:54
9b04e22
to
d604df2
Compare
lgtm, how do we test the test? |
Break something in core or in the tested extensions.
|
arcbtc
approved these changes
Mar 8, 2024
talvasconcelos
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add JMeter CI job and tests for some extensions.
In the future the tests that cover extensions should be moved to the
lnbits-extensions
repo and triggered when a PR is open for the extension or when dev branch oflnbits
is updated.Tests
The added tests cover:
Server
TPOS