Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused webhook handler for wallets #2288

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

dni
Copy link
Member

@dni dni commented Feb 21, 2024

it was only used in lnpay, opennode and alby which all had it disabled anayways with a pretty old TODO, so i guess the feature is disabled for a y ear now and nobody used it, so i just removed it

it was only used in lnpay, opennode and alby which all had it disabled anayways with a pretty old TODO, so i guess the feature is disabled for a y ear now and nobody used it, so i just removed it
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe12ecc) 59.28% compared to head (91d9e25) 59.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2288      +/-   ##
==========================================
+ Coverage   59.28%   59.31%   +0.02%     
==========================================
  Files          60       60              
  Lines        9029     9010      -19     
==========================================
- Hits         5353     5344       -9     
+ Misses       3676     3666      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dni dni added this to the 0.12.3 milestone Feb 21, 2024
Copy link
Collaborator

@motorina0 motorina0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
nice clean-up

@prusnak prusnak merged commit e419c74 into dev Feb 21, 2024
22 checks passed
@prusnak prusnak deleted the chore-remove-webhookhandler branch February 21, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants