Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update black to 24.2.0 and ruff to 0.3.0 #2307

Merged
merged 2 commits into from
Mar 7, 2024
Merged

update black to 24.2.0 and ruff to 0.3.0 #2307

merged 2 commits into from
Mar 7, 2024

Conversation

prusnak
Copy link
Collaborator

@prusnak prusnak commented Mar 2, 2024

No description provided.

@prusnak prusnak requested review from dni and motorina0 March 2, 2024 16:46
@prusnak prusnak added this to the 0.12.3 milestone Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 58.55%. Comparing base (cb5c9b0) to head (272b75f).

Files Patch % Lines
lnbits/core/views/api.py 0.00% 1 Missing ⚠️
lnbits/extension_manager.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2307   +/-   ##
=======================================
  Coverage   58.55%   58.55%           
=======================================
  Files          61       61           
  Lines        9185     9185           
=======================================
  Hits         5378     5378           
  Misses       3807     3807           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ignore = []

# Allow autofix for all enabled rules (when `--fix`) is provided.
fixable = ["ALL"]
unfixable = []

# Exclude a variety of commonly ignored directories.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come these directories do not have to be excluded anymore?

Copy link
Collaborator Author

@prusnak prusnak Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because i changed exclude to extend-exclude which keeps the default excluded dirs and only extends them (also the default automatically excludes what is in the .gitignore)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@arcbtc arcbtc self-requested a review March 7, 2024 09:29
@arcbtc arcbtc merged commit 3e341a3 into dev Mar 7, 2024
23 checks passed
@arcbtc arcbtc deleted the new-black-new-ruff branch March 7, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants