Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pending property for PaymentStatus #2324

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Conversation

motorina0
Copy link
Collaborator

@motorina0 motorina0 commented Mar 14, 2024

A payment status is pending when the paid value is none.

In the old implementation if a payment was failed (paid == False) then the pending property would be True (which is incorrect)

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 57.83%. Comparing base (352fd23) to head (2287503).

Files Patch % Lines
lnbits/wallets/lnbits.py 0.00% 7 Missing ⚠️
lnbits/wallets/fake.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2324      +/-   ##
==========================================
- Coverage   58.56%   57.83%   -0.74%     
==========================================
  Files          61       61              
  Lines        9210     9218       +8     
==========================================
- Hits         5394     5331      -63     
- Misses       3816     3887      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motorina0 motorina0 marked this pull request as ready for review March 14, 2024 08:39
@motorina0
Copy link
Collaborator Author

fixing failed jobs...

@motorina0 motorina0 merged commit d44339b into dev Mar 14, 2024
23 checks passed
@motorina0 motorina0 deleted the fix_pending_payment_property branch March 14, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants