feat: reduce initial requests on wallet page #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dni
commented
Mar 21, 2024
dni
commented
- refactor allowed_currencies into function to use in generic and api.
- remove currencies request in frontend move it to generic
- dont request balance on first payments fetch
dni
changed the title
dni
force-pushed
the
duplicate-wallet-req
branch
from
b395a5f
to
fec8790
Compare
dni
force-pushed
the
optimize-wallet
branch
2 times, most recently
from
7e381f6
to
d8ce6f7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2335 +/- ##
==========================================
- Coverage 58.49% 58.49% -0.01%
==========================================
Files 61 61
Lines 9266 9268 +2
==========================================
+ Hits 5420 5421 +1
- Misses 3846 3847 +1 ☔ View full report in Codecov by Sentry. |
talvasconcelos
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.