hotfix: initial currency conversion on balance #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiat amount not shown in balance on initial pageload, lets reintroduce the first fetch_balance to fix it. maybe in the future balance call and wallet itself should give the current fiat value if the wallet uses fiat tracking
|
Please also remove initial balance assignment from |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2346 +/- ##
==========================================
+ Coverage 58.50% 58.51% +0.01%
==========================================
Files 61 61
Lines 9268 9268
==========================================
+ Hits 5422 5423 +1
+ Misses 3846 3845 -1 ☔ View full report in Codecov by Sentry. |
|
done! |
motorina0
approved these changes
Mar 24, 2024
talvasconcelos
approved these changes
Mar 26, 2024
bitkarrot
pushed a commit
to bitkarrot/lnbits-legend
that referenced
this pull request
Mar 28, 2024
* hotfix: initial currency conversion on balance fiat amount not shown in balance on initial pageload, lets reintroduce the first fetch_balance to fix it. maybe in the future balance call and wallet itself should give the current fiat value if the wallet uses fiat tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fiat amount not shown in balance on initial pageload, lets reintroduce the first fetch_balance to fix it.
maybe in the future balance call and wallet itself should give the current fiat value if the wallet uses fiat tracking so you dont need the extra conversion call