bug: When "expiry" is null, do not display "expiry" in payment details

[dethos]

Fixes: #2194

null is a valid value for the expiry field of payment records. Which means that when this value is not populated, payment.expirydate and payment.expirydateFrom will be generated from an invalid Date (new Date(null*1000), which renders to 1970-01-01 or 1969-12-31 depending on the timezone).

This PR hides the expiry line from the payment details, when there is no information about it, just like it is done with preimage.

Note: for the change to be effective, we need to execute make bundle. However, it is not clear whether a new generated bundle should be included with every PR or not.

[dni]

thanks for the contribution! cACK

but something still wrong with the bundle, as of right now we still include it in prs

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.35%. Comparing base (c101b85) to head (b9cc1a3).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #2349      +/-   ##
==========================================
+ Coverage   58.34%   58.35%   +0.01%     
==========================================
  Files          61       61              
  Lines        9334     9334              
==========================================
+ Hits         5446     5447       +1     
+ Misses       3888     3887       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dethos]

thanks for the contribution! cACK

but something still wrong with the bundle, as of right now we still include it in prs

Fixed

[motorina0]

LGTM