Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify description in i18n #2356

Merged
merged 2 commits into from
Mar 28, 2024
Merged

simplify description in i18n #2356

merged 2 commits into from
Mar 28, 2024

Conversation

prusnak
Copy link
Collaborator

@prusnak prusnak commented Mar 24, 2024

so we[1] do not have to always edit description when a new funding source is added

[1] and by "we" I obviously mean bitkarrot :D

@prusnak prusnak requested review from dni and motorina0 March 24, 2024 23:44
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.31%. Comparing base (1dd0962) to head (0a6384b).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2356   +/-   ##
=======================================
  Coverage   58.31%   58.31%           
=======================================
  Files          61       61           
  Lines        9336     9336           
=======================================
  Hits         5444     5444           
  Misses       3892     3892           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitkarrot
Copy link
Contributor

ACK!

prusnak and others added 2 commits March 28, 2024 08:56
so we do not have to always edit description when a new funding source is added
@motorina0 motorina0 added this to the 0.12.5 milestone Mar 28, 2024
@dni dni merged commit aaa6573 into dev Mar 28, 2024
23 checks passed
@dni dni deleted the simplify-description branch March 28, 2024 08:06
bitkarrot pushed a commit to bitkarrot/lnbits-legend that referenced this pull request Mar 28, 2024
* simplify description in i18n
so we do not have to always edit description when a new funding source is added
* chore: make bundle

---------

Co-authored-by: dni ⚡ <office@dnilabs.com>
bitkarrot pushed a commit to bitkarrot/lnbits-legend that referenced this pull request Mar 29, 2024
* simplify description in i18n
so we do not have to always edit description when a new funding source is added
* chore: make bundle

---------

Co-authored-by: dni ⚡ <office@dnilabs.com>
bitkarrot pushed a commit to bitkarrot/lnbits-legend that referenced this pull request Mar 29, 2024
* simplify description in i18n
so we do not have to always edit description when a new funding source is added
* chore: make bundle

---------

Co-authored-by: dni ⚡ <office@dnilabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants