-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify description in i18n #2356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2356 +/- ##
=======================================
Coverage 58.31% 58.31%
=======================================
Files 61 61
Lines 9336 9336
=======================================
Hits 5444 5444
Misses 3892 3892 ☔ View full report in Codecov by Sentry. |
dni
approved these changes
Mar 25, 2024
ACK! |
motorina0
approved these changes
Mar 28, 2024
so we do not have to always edit description when a new funding source is added
dni
force-pushed
the
simplify-description
branch
from
March 28, 2024 07:56
de3099b
to
0a6384b
Compare
bitkarrot
pushed a commit
to bitkarrot/lnbits-legend
that referenced
this pull request
Mar 28, 2024
* simplify description in i18n so we do not have to always edit description when a new funding source is added * chore: make bundle --------- Co-authored-by: dni ⚡ <office@dnilabs.com>
bitkarrot
pushed a commit
to bitkarrot/lnbits-legend
that referenced
this pull request
Mar 29, 2024
* simplify description in i18n so we do not have to always edit description when a new funding source is added * chore: make bundle --------- Co-authored-by: dni ⚡ <office@dnilabs.com>
bitkarrot
pushed a commit
to bitkarrot/lnbits-legend
that referenced
this pull request
Mar 29, 2024
* simplify description in i18n so we do not have to always edit description when a new funding source is added * chore: make bundle --------- Co-authored-by: dni ⚡ <office@dnilabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we[1] do not have to always edit description when a new funding source is added
[1] and by "we" I obviously mean bitkarrot :D