-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests for alby #2390
test: add tests for alby #2390
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2390 +/- ##
==========================================
+ Coverage 59.46% 59.97% +0.50%
==========================================
Files 65 65
Lines 9404 9441 +37
==========================================
+ Hits 5592 5662 +70
+ Misses 3812 3779 -33 ☔ View full report in Codecov by Sentry. |
return PaymentResponse(False, None, None, None, error_message) | ||
|
||
checking_id = data["payment_hash"] | ||
# todo: confirm with bitkarrot that having the minus is fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @bitkarrot ☝️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fee value returned by Alby is positive.
@motorina0 ok gimme a day to check this out. |
028b01c
to
653d6a6
Compare
Summary
alby
alby.py
to follow theBaseWallet
interfaceTwo open questions for @bitkarrot:
fee
value negative?keysend
payments ("fee": 1
)preimage
for the outgoing payments. I can see in the docs that the generic endpoint (/invoices/{checkin_id}
) does not return the pre-image, but the dedicated endpoints do (/invoices/incoming/{checkin_id}
, (/invoices/outgoing/{checkin_id}
)).See the
"skip": true
tests for more details.