Mega-merge 3: CLN update client lib with descriptionhash support #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callebtc
changed the title
Codecov Report
@@ Coverage Diff @@
## main #792 +/- ##
==========================================
+ Coverage 41.72% 41.85% +0.12%
==========================================
Files 216 216
Lines 11372 11373 +1
==========================================
+ Hits 4745 4760 +15
+ Misses 6627 6613 -14
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This adds a wrapper around uvicorn using Python. This is so the entrypoint lnbits.server can be called on the command line, and passed arguments like port and host. This makes lnbits feel more like a real CLI application, and lends well to running as a service in systemd
This commit is not exhaustive, and it is a trend in this codebase to not use StaticFiles() and instead use relative paths. This means the code cannot run anywhere other than the source code directory, as it will not find the files it is looking for
This causes lnbits.nixosModules.default to exist, rather than lnbits.nixosModules.aarch64-linux.default. The latter was a mistake.
* fix older tpos without tips * bad math requesting invoice * make format
Fixed issue scanning tickets by adding "ticket://" prefix
callebtc
changed the title
5 tasks
callebtc
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v0.11.1, CLN supports generating invoices with deschashonly enabling native support for LNURL.
desciption_hashwithoutinvoicewithdescriptionhashpluginpayment_hashaschecking_idinstead oflabelchecking_idispayment_hashfor checking an invoice status.pylightningtopyln-clientCLightningWalletrenamed toCoreLightningWallet(keep support for old name / .env files)CLIGHTNING_RPCrenamed toCORELIGHTNING_RPC(keep support for old name / .env files)clightning.pytocln.pyTesting: All tests in the PR should pass.