Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Consistent naming of terms #175

Closed
8go opened this issue Apr 15, 2020 · 4 comments
Closed

Editorial: Consistent naming of terms #175

8go opened this issue Apr 15, 2020 · 4 comments
Labels
editorial

Comments

@8go
Copy link
Contributor

8go commented Apr 15, 2020

All terms should be used consistently.

In chapter 2 there is a lot of talk about Lightning wallets. These are the terms I found:

  • lightning wallet
  • Lightning wallet
  • LN Wallet

I suggest to always consistently use a single term: e.g. Lightning wallet. (Uppercase L, lowercase w). As in: "Alice is using a Lightning wallet."

Lightning wallet is just one example. There are many other terms that I have seen used differently in different paragraphs. (Blockchain vs blockchain, etc.)

Which part needs editing?
everything needs to be revised

What editing does this need?
replace with agreed upon term(s)

How does it currently read?
e.g.

  • lightning wallet
  • Lightning wallet
  • LN Wallet

How should it read?
e.g.

  • Lightning wallet

Again, if people think this is a good idea and should be done, then I can start a list, make the agreed upon changes and submit the corresponding PR(s). Just let me know.
@8go 8go added the editorial label Apr 15, 2020
@Roasbeef
Copy link
Contributor

+1 for "Lightning wallet", I think a PR is welcome here.

@8go
Copy link
Contributor Author

8go commented Apr 29, 2020

I have a bunch of PRs outstanding. Once they are pulled, I will create a PR for this.

8go pushed a commit to 8go/lnbook that referenced this issue Jun 18, 2020
Globally replaced "LN Wallet" with "Lightning Wallet"
7796b43 
- see also Issue lnbook#175
8go pushed a commit to 8go/lnbook that referenced this issue Jun 18, 2020
global replacement of "LN Wallet" with "Lightning Wallet"
e543691 
- see also Issue lnbook#175 
- 3 occurrences replaced
@8go 8go mentioned this issue Jun 18, 2020
Merged
@8go
Copy link
Contributor Author

8go commented Jun 18, 2020

Put in PR for this: see PR #265

8go pushed a commit to 8go/lnbook that referenced this issue Jun 18, 2020
ch02: global replacement of "LN Node" with "Lightning Node"
827b7ca 
- see also Issue lnbook#174 
- see also Issue lnbook#175 
- is is also "Bitcoin Node", not "Bitcoin Network Node"
- simpler is better, shorter is better
- 7 occurrences were replaced
@8go 8go mentioned this issue Jun 18, 2020
Merged
8go pushed a commit to 8go/lnbook that referenced this issue Jun 18, 2020
ch02: global replacement of "LN Invoice" with "Lightning Invoice"
e77ccf5 
- similar to PR lnbook#268 and PR lnbook#269 
- issues lnbook#174 and lnbook#175 
- 1 occurrence only 
- "Lightning Invoice" was already used in text, this fixes also the inconsistency
@8go 8go mentioned this issue Jun 18, 2020
Merged
renepickhardt pushed a commit that referenced this issue Jun 20, 2020
ch02: global replacement of "LN Invoice" with "Lightning Invoice" (#270)
d1ae621 
- similar to PR #268 and PR #269 
- issues #174 and #175 
- 1 occurrence only 
- "Lightning Invoice" was already used in text, this fixes also the inconsistency
renepickhardt pushed a commit that referenced this issue Jun 20, 2020
ch02: global replacement of "LN Node" with "Lightning Node" (#268)
cbbf959 
- see also Issue #174 
- see also Issue #175 
- is is also "Bitcoin Node", not "Bitcoin Network Node"
- simpler is better, shorter is better
- 7 occurrences were replaced
renepickhardt pushed a commit that referenced this issue Jun 20, 2020
global replacement of "LN Wallet" with "Lightning Wallet" (#265)
73ab568 
- see also Issue #175 
- 3 occurrences replaced
@8go
Copy link
Contributor Author

8go commented Jun 29, 2020

In chapters ch01 thru ch03 this has been taken care off with the latest merges.
Closing this issue now.

@8go 8go closed this as completed Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editorial
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Roasbeef @8go