26 0 version of bitcoin #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add sjors key
|
Looks like the sha256sums do not match. # https://bitcoincore.org/bin/bitcoin-core-26.0/
% grep "bitcoin-26.0.tar.gz" SHA256SUMS
ab1d99276e28db62d1d9f3901e85ac358d7f1ebcb942d348a9c4e46f0fcdc0a1 bitcoin-26.0.tar.gz
# From releases page https://github.com/bitcoin/bitcoin/releases/tag/v26.0
% sha256sum bitcoin-26.0.tar.gz
3eb7c1e35de9415f82737e48cdc6f0e7f4b75973cb123996662c1650f6d544cf bitcoin-26.0.tar.gz |
|
From https://github.com/bitcoin/bitcoin/releases/tag/v26.0 Change the source download url to https://bitcoincore.org/bin/bitcoin-core-26.0/ and it works. |
lnliz
reviewed
Dec 29, 2023
fanquake
reviewed
Dec 29, 2023
| # Download checksums | ||
| ADD https://bitcoincore.org/bin/bitcoin-core-$VERSION/SHA256SUMS ./ | ||
|
|
||
| # Download source code from same website as github is probably deterministicly built |
There was a problem hiding this comment.
I think this comment needs fixing. GitHub might be deterministic, but it doesn't match our source tarballs, which are also deterministic. This comment seems to imply that our tarballs are not deterministic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 26-0 version of bitcoind containers