Skip to content

Commit

Permalink
Updated godoc to remove some incorrect claims on proprietary version
Browse files Browse the repository at this point in the history
performance.
  • Loading branch information
lni committed Jan 11, 2019
1 parent 1d536af commit db56034
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 0 additions & 2 deletions internal/logdb/sharded_rdb.go
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ var (
) )


// ShardedRDB is a LogDB implementation using sharded rocksdb instances. // ShardedRDB is a LogDB implementation using sharded rocksdb instances.
// This is the community version of the ShardedRDB known to be less optimal in
// terms of both IO latency and throughput.
type ShardedRDB struct { type ShardedRDB struct {
completedCompactions uint64 completedCompactions uint64
shards []*RDB shards []*RDB
Expand Down
6 changes: 3 additions & 3 deletions internal/raft/logentry.go
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ type ILogDB interface {
Append(entries []pb.Entry) error Append(entries []pb.Entry) error
} }


// the community version of dragonboat uses a two stage entryLog implementation // entryLog is the entry log used by Raft. It splits entries into two parts -
// similar to the one used by etcd raft, it is known to be not optimal. // those will be immediately used and those unlikely to be used in normal fast
// the proprietary version uses a more throughput friendly approach. // path.
type entryLog struct { type entryLog struct {
logdb ILogDB logdb ILogDB
inmem inMemory inmem inMemory
Expand Down

0 comments on commit db56034

Please sign in to comment.