FOFB system identification features: ABI #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermerc
force-pushed
the
sys-id-cheby
branch
from
5276899
to
e2dc1c0
Compare
guilhermerc
force-pushed
the
sys-id-feats
branch
from
96bf5c2
to
fcf6332
Compare
guilhermerc
force-pushed
the
sys-id-cheby
branch
from
e2dc1c0
to
5cad941
Compare
guilhermerc
changed the title
guilhermerc
force-pushed
the
sys-id-cheby
branch
3 times, most recently
from
7c356ea
to
b51fb40
Compare
guilhermerc
force-pushed
the
sys-id-feats
branch
from
fcf6332
to
37d6f3d
Compare
guilhermerc
force-pushed
the
sys-id-cheby
branch
5 times, most recently
from
a4ad0fb
to
a9a01c2
Compare
ericonr
reviewed
Apr 27, 2023
augustofg
requested changes
Apr 27, 2023
guilhermerc
force-pushed
the
sys-id-cheby
branch
4 times, most recently
from
fcd9671
to
9a8c677
Compare
|
I've addressed all the requested changes. |
ericonr
approved these changes
Apr 28, 2023
guilhermerc
force-pushed
the
sys-id-cheby
branch
6 times, most recently
from
ea8ddd1
to
a065d3a
Compare
guilhermerc
force-pushed
the
sys-id-cheby
branch
3 times, most recently
from
e32e1a0
to
0102379
Compare
Merged
guilhermerc
force-pushed
the
sys-id-cheby
branch
8 times, most recently
from
0de1fcf
to
ff3341e
Compare
Add trigger interface to effectivate what was set via wishbone on PRBS_CTL_RST, PRBS_CTL_BPM_POS_DISTORT_EN and PRBS_CTL_SP_DISTORT_EN. Since this changes the ABI behavior, but not drastically, its minor version number is being increased (v1.1).
As per aaead18, the remaining FOFB channels are now instantiated.
These will be useful for debugging. TODO: still have to assert these on xwb_fofb_sys_id_tb.vhd
Logical triggers IDs allocated for things other than acquisitions must begin right after the last acquisition channel ID.
Uses the same format as the regular sys id channel, but probes the distorted versions of its signals.
Rename g_MAX_NUM_BPM_POS to g_MAX_NUM_BPM_POS_PER_FLAT so its clearer that this is a value applied for each flatenizer.
These pulse syncers guarantee that we won't acquire/change stuff in the middle of a FOFB cycle.
Cheby's generated header has a mismatching between WB_FOFB_SYS_ID_REGS_PRBS_BPM_POS_DISTORT_DISTORT_RAM macro and 'struct bpm_pos_distort' offset. This is temporarily fixed by proper padding the struct.
|
@augustofg , can you take a last glance on this PR, please? |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for
fofb_sys_idfirst production ABI.