Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update afc-gw submodule, remove AFCv3 support #34

Merged
merged 2 commits into from
May 10, 2024
Merged

Update afc-gw submodule, remove AFCv3 support #34

merged 2 commits into from
May 10, 2024

Conversation

augustofg
Copy link
Member

No description provided.

@augustofg
Remove support for AFCv3 boards
2f26250 
These synthesis targets are not updated since a long time, we don't
use them anymore. Remove them.
@augustofg augustofg requested a review from guilhermerc May 7, 2024 19:56
guilhermerc
guilhermerc requested changes May 10, 2024
View reviewed changes
Copy link
Contributor

@guilhermerc guilhermerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also forgot to remove the support for g_BOARD = "AFCv3" and g_RTM = "RTMSFP" from hdl/top/afc_ref_design_gen/afc_ref_fofb_ctrl_gen.vhd.

hdl/top/afc_ref_design_gen/afc_ref_fofb_ctrl_gen.vhd Show resolved Hide resolved
@augustofg
Update afc-gw submodule to replace rs232_syscon with xwb_master_uart
4e75cff 
The rs232_syscon core is hard to use from a software perspective, and
it had some bug that caused frequent hangs during usage.
xwb_master_uart is a much simpler implementation solves these issues.
@augustofg
Copy link
Member Author

You also forgot to remove the support for g_BOARD = "AFCv3" and g_RTM = "RTMSFP" from hdl/top/afc_ref_design_gen/afc_ref_fofb_ctrl_gen.vhd.

I prefer keeping the afc_ref_fofb_ctrl_gen.vhd file as it is, not fully removing support to AFCv3 as it doesn't hurt. I've only removed the top level entities and synthesis targets as these weren't used anymore and weren't in sync with the latest developments.

If we desire to fully remove AFCv3 support, then it would make sense to delete afc_ref_fofb_ctrl_gen and move all top level logic to afcv4_ref_fofb_ctrl.vhd.

@guilhermerc
Copy link
Contributor

You also forgot to remove the support for g_BOARD = "AFCv3" and g_RTM = "RTMSFP" from hdl/top/afc_ref_design_gen/afc_ref_fofb_ctrl_gen.vhd.

I prefer keeping the afc_ref_fofb_ctrl_gen.vhd file as it is, not fully removing support to AFCv3 as it doesn't hurt. I've only removed the top level entities and synthesis targets as these weren't used anymore and weren't in sync with the latest developments.

If we desire to fully remove AFCv3 support, then it would make sense to delete afc_ref_fofb_ctrl_gen and move all top level logic to afcv4_ref_fofb_ctrl.vhd.

Got it!

@guilhermerc guilhermerc merged commit 87b28e9 into devel May 10, 2024
1 check passed
@guilhermerc guilhermerc deleted the update-afc-gw-remove-afcv3 branch May 10, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhermerc guilhermerc guilhermerc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@augustofg @guilhermerc