Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export function get_family_data #16

Closed
fernandohds564 opened this issue Sep 23, 2015 · 1 comment
Closed

Export function get_family_data #16

fernandohds564 opened this issue Sep 23, 2015 · 1 comment
Labels

Comments

@fernandohds564
Copy link
Contributor

I don't think it is a good idea to export the family_data dictionary. Instead, it would be better to export the function get_family_data, because sometimes we change the number of elements of the accelerator, for example when we insert ids in the model, which will break the information in the dictionary, created when the module is imported.

What do you think, @afonsoharuo , @xresende , @LuanaVilela ?

@xresende
Copy link
Contributor

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants