Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for sampling efficiency #15

Open
lo-co opened this issue Jan 26, 2016 · 1 comment
Open

Proposal for sampling efficiency #15

lo-co opened this issue Jan 26, 2016 · 1 comment

Comments

@lo-co
Copy link
Owner

lo-co commented Jan 26, 2016

I haven't thought this out to much yet, but I think that we might be able to provide a nicer API for the sampling efficiency. My suggestion is to have a root class that is a composition of it's children. The root class has a single method get_efficiency or something like that that will serve as the signature for returning an efficiency or array of efficiencies. This class might also have some attributes such as diameter and efficiency. Then, the children would implement the details and decorate the parent with methods and attributes specific to that implementation. The get_efficiency in the parent object would then be a product of the overriden methods in the children. This sounds confusing so I will try to show what I mean. All of Hagen's calculations in the existing module would remain the same.

@hagne
Copy link
Collaborator

hagne commented Jan 26, 2016

sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants