Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending Oimo shapes from outside #48

Open
jagenjo opened this issue Feb 20, 2017 · 0 comments
Open

Extending Oimo shapes from outside #48

jagenjo opened this issue Feb 20, 2017 · 0 comments

Comments

@jagenjo
Copy link

jagenjo commented Feb 20, 2017

Hi:

I'm trying to adapt Oimo to my special needs for my application, that requires some new collision shapes. The problem is that Oimo do not allow to extend it easily without modifying the lib itself, because any collision detector must inherit from CollisionDetector but that class is not public so I cannot extend it without editing the lib, which will cause problems in future updates.

Also the world.add function allows to pass the shape as an string, but the possible values are hardcoded in a switch. I suggest to have a container to associate shape names with the class representing it.

I will make the changes myself but I dont feel confident enough yet.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant