Merge pull request #292 from lo1tuma/no-skipped

Improve no-skipped performance
lo1tuma · May 26, 2021 · d830482 · d830482
2 parents 8634d89 + acf31a0
commit d830482
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/benchmarks/runtime.bench.js b/benchmarks/runtime.bench.js
@@ -92,7 +92,7 @@ function lintManyFilesWithAllRecommendedRules({ numberOfFiles }) {
 describe('runtime', () => {
     it('should not take longer as the defined budget to lint many files with the recommended config', () => {
         const nodeVersionMultiplier = getNodeVersionMultiplier();
-        const budget = 3500000 / cpuSpeed * nodeVersionMultiplier;
+        const budget = 3750000 / cpuSpeed * nodeVersionMultiplier;
 
         const { medianDuration } = runBenchmark(() => {
             lintManyFilesWithAllRecommendedRules({ numberOfFiles: 350 });
@@ -102,7 +102,7 @@ describe('runtime', () => {
     });
 
     it('should not consume more memory as the defined budget to lint many files with the recommended config', () => {
-        const budget = 2500000;
+        const budget = 2750000;
 
         const { medianMemory } = runBenchmark(() => {
             lintManyFilesWithAllRecommendedRules({ numberOfFiles: 350 });

diff --git a/lib/rules/no-skipped-tests.js b/lib/rules/no-skipped-tests.js
@@ -11,14 +11,18 @@ module.exports = {
     },
     create(context) {
         const astUtils = createAstUtils(context.settings);
+        const options = { modifiers: [ 'skip' ], modifiersOnly: true };
+        const isTestCase = astUtils.buildIsTestCaseAnswerer(options);
+        const isDescribe = astUtils.buildIsDescribeAnswerer(options);
 
         return {
             CallExpression(node) {
-                const options = { modifiers: [ 'skip' ], modifiersOnly: true };
-
-                if (astUtils.isDescribe(node, options) || astUtils.isTestCase(node, options)) {
+                if (isDescribe(node) || isTestCase(node)) {
                     const callee = node.callee;
-                    const nodeToReport = callee.type === 'MemberExpression' ? callee.property : callee;
+                    const nodeToReport =
+                        callee.type === 'MemberExpression' ?
+                            callee.property :
+                            callee;
 
                     context.report({
                         node: nodeToReport,