Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule proposal: no async in describe callback #189

Closed
michielmulders opened this issue Feb 13, 2019 · 2 comments
Closed

Rule proposal: no async in describe callback #189

michielmulders opened this issue Feb 13, 2019 · 2 comments

Comments

@michielmulders
Copy link

michielmulders commented Feb 13, 2019

According to this issue with Mocha (Describe block with async function behaving weirdly #2975),
it is not recommended to use the async keyword in the describe callback argument.

Example piece of code to avoid:

describe('yyy', async () => {

});

Preferred code:

describe('yyy', () => {

});

Would you like to consider this rule?
Thanks for your time!

@lo1tuma
Copy link
Owner

lo1tuma commented Feb 13, 2019

Yes, such a rule makes definitely sense. There is already a PR which implements this, see #188.

@lo1tuma
Copy link
Owner

lo1tuma commented Feb 13, 2019

Fixed by #188 and released in v5.3.0.

@lo1tuma lo1tuma closed this as completed Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants