Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-skipped-tests should not be autofixable #242

Closed
robinclaes opened this issue Apr 1, 2020 · 1 comment · Fixed by #258
Closed

no-skipped-tests should not be autofixable #242

robinclaes opened this issue Apr 1, 2020 · 1 comment · Fixed by #258

Comments

@robinclaes
Copy link

Hi all,

The no-skipped-tests autofix replaces it.skip() with it()

In my opinion, this should not happen as this actually alters the way tests are run.
The rule is definitely valid, but I suggest not making this autofixable.

What do you guys think? I'd be happy to submit a PR.
@lo1tuma
Copy link
Owner

lo1tuma commented May 13, 2020

Personally I don’t have a strong opinion on that since I never use skipped tests. We already decided a while ago to remove the autofix feature from no-exclusive-tests because editors or IDEs automatically apply autofixes all the time and it becomes annoying when you want to run only one test from your IDE.

LukaPrebil pushed a commit to LukaPrebil/eslint-plugin-mocha that referenced this issue Jul 28, 2020
remove autofix from no-skipped-tests rule, fix lo1tuma#242
eb19eb6
@LukaPrebil LukaPrebil mentioned this issue Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove autofix from no-skipped-tests rule fix LukaPrebil/eslint-plugin-mocha
2 participants
@lo1tuma @robinclaes