Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-mocha-arrow fixer #118

Merged
merged 1 commit into from Dec 14, 2016
Merged

Fix no-mocha-arrow fixer #118

merged 1 commit into from Dec 14, 2016

Conversation

jfmengels
Copy link
Collaborator

When a test implementation has parameters, the end result would have missing parens.

it(done => {});
// -->
it(function done {});

This fixes it. I could not keep a consistent spacing for function () {} and function() {}, so I modified the current results, but when fixing, that will probably be taken care of the other rules' fixers anyway.

cc @rhysd if you feel like reviewing

Copy link
Owner

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhysd
Copy link
Contributor

rhysd commented Dec 13, 2016

Ah, you're correct. Thank you for the fix.

@jfmengels jfmengels merged commit 0ab2f58 into master Dec 14, 2016
@jfmengels jfmengels deleted the fix-no-mocha-arrow-fixer branch December 14, 2016 08:58
@lo1tuma lo1tuma added the bug label Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants