Added support for async functions in no-synchronous-tests #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
To validate |
lo1tuma
reviewed
Jun 16, 2017
lib/rules/no-synchronous-tests.js
Outdated
| } | ||
|
|
||
| return callee.name; | ||
| function getCalleeName(callee) { |
There was a problem hiding this comment.
I know this function was already there before but it would be nice to re-use the getNodeName method from our AST utils.
💅
lo1tuma
reviewed
Jun 16, 2017
lib/rules/no-synchronous-tests.js
Outdated
| // allow arrow statements calling a promise with implicit return. | ||
| returnStatement = bodyStatement; | ||
| } | ||
| function getAllowedAsyncMethocsFromOptions(options) { |
There was a problem hiding this comment.
Typo? I guess it should be getAllowedAsyncMethodsFromOptions.
lo1tuma
requested changes
Jun 16, 2017
|
I have implemented the requested changes. I am using isTestCase/isHookIdentifier from ast utils and got rid of the list of identifiers for tests/hooks in no-synchronous-tests. |
lo1tuma
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One note: the updated rule throws errors when the provided options do not match a certain format.
eslint itself usually does not test those exception cases (it ignores them for code coverage: https://github.com/eslint/eslint/blob/master/lib/rules/new-cap.js#L38) and I wasn't sure how to test an exception with the RuleTester so I ignored those cases as well.