Add new rule handle-done-callback #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now the rule performs a really simple check and may not cover each possible use-case. * It doesn’t include branch-tracking to make sure that the done callback is callend in every possible branch * It doesn’t check HOW the callback is handled, so e.g. `return done;` would be sufficient.
lo1tuma
force-pushed
the
handle-done-callback
branch
from
7869ce9
to
ff545b0
Compare
| it('should work', function (done) { | ||
| fetchData(options, function (error, data) { | ||
| expect(error).not.to.be.ok; | ||
| expect(data).to.deep.equal({ foo: 'bar' }); |
There was a problem hiding this comment.
You could add a comment below this line like // The done callback was not called to make this even more clear.
|
I really like this rule 👍! It seems to work and everything looks fine (apart from my small comments). |
|
Comments addressed 😉. I think the two points I mentioned in the PR description could be done in the future (we should file an issue for each). Maybe a generic branch-tracking approach will be implemented directly in ESlint. |
lxanders
pushed a commit
that referenced
this pull request
Jun 23, 2015
Add new rule handle-done-callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now the rule performs a really simple check and may not cover each
possible use-case.
donecallback is called in every possible branch.return done;would be sufficient.