Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoize names (increases speed by 10x) #280

Merged
merged 3 commits into from
May 25, 2021
Merged

Memoize names (increases speed by 10x) #280

merged 3 commits into from
May 25, 2021

Conversation

pasieronen
Copy link
Contributor

It looks like just memoizing getNamesByType speeds up the benchmark by more than 10x.

Closes #268.

@pasieronen pasieronen changed the title Memoize names Memoize names (increases speed by 10x) May 21, 2021
@lo1tuma
Copy link
Owner

lo1tuma commented May 25, 2021

Thanks. Can you also adjust the performance budgets in the performance tests accordingly? This should prevent us from introducing performance regressions in the future.

@pasieronen
Copy link
Contributor Author

@lo1tuma Adjusted the runtime duration budget to 1/10th (which is roughly what the improvement is on my laptop).

Copy link
Owner

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you 🍻!

@lo1tuma lo1tuma merged commit 9446d16 into lo1tuma:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance regression in 8.0.0
2 participants