Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-mocha-global-arrows: New rule #78

Merged
merged 1 commit into from Jul 22, 2016
Merged

no-mocha-global-arrows: New rule #78

merged 1 commit into from Jul 22, 2016

Conversation

paulmelnikow
Copy link

For #48

@coveralls
Copy link

coveralls commented Jul 12, 2016 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling b81be5b on bodylabs:no_mocha_global_arrows into 2f56017 on lo1tuma:master.

@paulmelnikow paulmelnikow mentioned this pull request Jul 12, 2016
Merged
lo1tuma
lo1tuma reviewed Jul 13, 2016
View reviewed changes
lib/rules/no-mocha-global-arrows.js
var callee = node.callee,
fnArg;

if (callee && callee.name && mochaFunctionNames.indexOf(callee.name) > -1) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work for function names like it.only. See how this is done in other rules.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks: b18e8ba

@coveralls
Copy link

coveralls commented Jul 13, 2016 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling b18e8ba on bodylabs:no_mocha_global_arrows into 2f56017 on lo1tuma:master.

@paulmelnikow
Copy link
Author

Okay, renamed and rebased.

@coveralls
Copy link

coveralls commented Jul 18, 2016 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 85beb27 on bodylabs:no_mocha_global_arrows into 2f56017 on lo1tuma:master.

@coveralls
Copy link

coveralls commented Jul 18, 2016 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 85beb27 on bodylabs:no_mocha_global_arrows into 2f56017 on lo1tuma:master.

@paulmelnikow
Copy link
Author

@lo1tuma Can you merge this?

@lo1tuma
Copy link
Owner

lo1tuma commented Jul 22, 2016

@paulmelnikow Sorry for the late response, I was traveling.

Thanks for your contribution, LGTM.

@lo1tuma lo1tuma merged commit 2b831fb into lo1tuma:master Jul 22, 2016
@lo1tuma lo1tuma mentioned this pull request Jul 22, 2016
Closed
@paulmelnikow
Copy link
Author

Thanks!

@paulmelnikow paulmelnikow mentioned this pull request Jul 22, 2016
Merged
@paulmelnikow paulmelnikow mentioned this pull request Apr 19, 2017
Merged
10 tasks
@paulmelnikow paulmelnikow mentioned this pull request Oct 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulmelnikow @coveralls @lo1tuma