Introduce --unreleased CLI option #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lo1tuma
reviewed
Dec 31, 2023
lo1tuma
reviewed
Dec 31, 2023
lo1tuma
reviewed
Dec 31, 2023
lo1tuma
reviewed
Dec 31, 2023
screendriver
force-pushed
the
unreleased
branch
from
1a52b58
to
c7d2f5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--unreleasedwill generate a changelog even when it was not released. It will then include a section for unreleased changes.--unreleasedwas specified it is not allowed to provide a version number--unreleasedwas not specified a version number is mandatory (the same behaviour as it is right now)Therefore I had to change the argument
version-numberfrom required (<version-number>) to always be optional ([version-number]) because there is no specification for having arguments optional or required depending on given options. Usually square brackets is for[optional option]and angle brackets for a<required argument>.I also introduced better handling of potential
undefinedvalues withMaybes and used alsoResults instead of throwing Errors.