-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update message definition #5
Conversation
The message type can only have 3 possible roles: "system" | "assistant" | "user". Messages can contain an optional name field. This is helpful in some applications, here's an example from OpenAI: https://github.com/openai/openai-cookbook/blob/main/examples/How_to_format_inputs_to_ChatGPT_models.ipynb.
Seems like this got added pretty recent. LGTM. |
@ferdousbhai please |
@load1n9 please publish a new version after this gets merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor, but could you revert changes to .gitignore
? Otherwise this looks great, thanks for the contribution!
Sure, sorry, my first pull request. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
The message type can only have 3 possible roles: "system" | "assistant" | "user".
Messages can contain an optional name field. This is helpful in some applications, here's an example from OpenAI: https://github.com/openai/openai-cookbook/blob/main/examples/How_to_format_inputs_to_ChatGPT_models.ipynb.