Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update message definition #5

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

ferdousbhai
Copy link
Contributor

The message type can only have 3 possible roles: "system" | "assistant" | "user".
Messages can contain an optional name field. This is helpful in some applications, here's an example from OpenAI: https://github.com/openai/openai-cookbook/blob/main/examples/How_to_format_inputs_to_ChatGPT_models.ipynb.

The message type can only have 3 possible roles: "system" | "assistant" | "user".
Messages can contain an optional name field. This is helpful in some applications, here's an example from OpenAI: https://github.com/openai/openai-cookbook/blob/main/examples/How_to_format_inputs_to_ChatGPT_models.ipynb.
@load1n9 load1n9 requested a review from lino-levan April 18, 2023 16:28
@lino-levan
Copy link
Collaborator

Seems like this got added pretty recent. LGTM.

@lino-levan
Copy link
Collaborator

@ferdousbhai please deno fmt.

@lino-levan
Copy link
Collaborator

@load1n9 please publish a new version after this gets merged

@lino-levan lino-levan changed the title Update Message definition fix: update message definition Apr 19, 2023
Copy link
Collaborator

@lino-levan lino-levan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor, but could you revert changes to .gitignore? Otherwise this looks great, thanks for the contribution!

@ferdousbhai
Copy link
Contributor Author

Sure, sorry, my first pull request. 😅

Copy link
Collaborator

@lino-levan lino-levan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lino-levan lino-levan merged commit 71e9888 into load1n9:master Apr 19, 2023
@ferdousbhai ferdousbhai deleted the fix/Message-type branch April 20, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants