Windows binary improvements

[imiric]

This enhances the Windows k6 binary by adding an icon and some release metadata like version information, visible in the file's Properties. Additionally, the k6.ico was updated to the new logo in higher resolution, and the MSI installer assets were updated as well.

Before:

After:

This is based on previous work in #1394 and the templating suggestion by @na--. We decided to abandon the templating approach in favor of passing metadata via CLI args.

You can inspect the binary if you download the build artifacts from here.

Pending work:

• I'll add MSI package signing (Sign release binaries and installers for Windows  #1034, Improve security and automation of official binary releases #1247) in a follow-up PR.
• As discussed I think we agree to get rid of the Version constant and rely only on Git tags, but I'll leave that change for later as well.

[imiric]

It would be better if consts.Version is not a real constant, but something like []uint16{0, 29, 0}, but that would involve a lot of other changes, and I think we should get this from Git anyway.

[codecov-io]

Codecov Report

Merging #1727 (437fd67) into master (d9bced3) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1727      +/-   ##
==========================================
- Coverage   71.52%   71.50%   -0.02%     
==========================================
  Files         178      178              
  Lines       13719    13727       +8     
==========================================
+ Hits         9812     9816       +4     
- Misses       3295     3299       +4     
  Partials      612      612              

Flag	Coverage Δ
ubuntu	71.48% <ø> (+0.01%)	⬆️
windows	70.05% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
core/engine.go	90.95% <0.00%> (-2.02%)	⬇️
stats/cloud/collector.go	79.81% <0.00%> (-0.64%)	⬇️
js/runner.go	81.10% <0.00%> (+0.65%)	⬆️
lib/types/hostnametrie.go	72.22% <0.00%> (+3.47%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9bced3...437fd67. Read the comment docs.

[na--]

I skimmed through the changes and at glance they LGTM, but to answer your questions:

• I'm fine with the .msi signing either being in the same PR or in a separate one, whatever you prefer
• CLI flags for goversioninfo seem slightly preferable - it will make the CI script a bit more verbose, but it'd be much easier to understand what's happening and there would be a lot fewer things that can go wrong
• not reading the Go Version const is probably fine... you should be able to get the git tag version out of some GitHub Actions environment variable, right?

[mstoykov]

LGTM, I agree with both of you on all the points :D .

I would like to remind people that PR numbers are free (until we are close to a power of 2 ;) ), so having (self-contained) changes spread over multiple PRs IMO is preferable ;)

[imiric]

I would like to remind people that PR numbers are free (until we are close to a power of 2 ;) ), so having (self-contained) changes spread over multiple PRs IMO is preferable ;)

True, but MSI package signing is closely related to this, and the less notifications I get and GitHub I have to use, the better :-P (See how I messed up the Assignees and Reviewers in this PR...)

But makes sense, I'll do that in another PR.

[na--]

LGTM