Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/app serializers #103

Merged
merged 7 commits into from
May 1, 2015
Merged

F/app serializers #103

merged 7 commits into from
May 1, 2015

Conversation

justinyost
Copy link
Contributor

Adds an AppSerializer class and documentation regarding the use of it.

Note there are no breaking changes in this PR, however the documentation is updated to reflect that AppSerializer class will probably be the primary base Serializer object developers will build upon.
Closes #53

References #53

Signed-off-by: Justin Yost <justin@loadsys.com>
References #53

Signed-off-by: Justin Yost <justin@loadsys.com>
@justinyost justinyost self-assigned this Apr 25, 2015
@justinyost justinyost added this to the 1.0 Release milestone Apr 25, 2015
@justinyost justinyost added review and removed wip labels Apr 25, 2015
@justinyost justinyost assigned beporter and unassigned justinyost Apr 25, 2015
@justinyost
Copy link
Contributor Author

Assigning to @beporter for review and feedback.

Signed-off-by: Justin Yost <justin@loadsys.com>
@beporter
Copy link

One specific thing comes to mind:

Does this work even if the consuming Cake project does not have a /Serializer/AppSerializer.php file defined? I'm thinking of how Cake controller's can extend AppController without there actually needing to be a /Controller/AppController.php file in your project.

It seems like the App class needs to know about Plugin/Serializers/Serializer/ as a load path for Serializer objects. All a /Serializer/SomethingSerializer.php file should need to do is App::uses('AppSerializer', 'Serializer'); and have it work whether or not /Serializer/AppSerializer.php exists by falling back to Plugin/Serializers/Serializer/AppSerializer.php.

In other words: It should work exactly like AppController and AppModel.

@beporter beporter assigned justinyost and unassigned beporter Apr 27, 2015
Adds path to both the App Serializer Path
Also adds path to the Serializers Plugin Path

Signed-off-by: Justin Yost <justin@loadsys.com>
Only needs to know about the Serializer object, not the path to the plugin object

Signed-off-by: Justin Yost <justin@loadsys.com>
Signed-off-by: Justin Yost <justin@loadsys.com>
@justinyost
Copy link
Contributor Author

@beporter Throwing back for re-review.

@justinyost justinyost assigned beporter and unassigned justinyost Apr 29, 2015
@beporter
Copy link

Nice work, this looks like it mirrors the behavior of Cake's core classes (Models, Controllers, Components, etc.) when it comes to using a core AppWhatever when one is not present in the app.

👍

@beporter beporter assigned justinyost and unassigned beporter Apr 29, 2015
@justinyost
Copy link
Contributor Author

Need to run through this PR and verify it internally before merging.

Signed-off-by: Justin Yost <justin@loadsys.com>
justinyost added a commit that referenced this pull request May 1, 2015
@justinyost justinyost merged commit 8591b97 into master May 1, 2015
@justinyost justinyost deleted the f/app-serializers branch May 1, 2015 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Work out a solution for people to be able to build/use a type of AppSerializer Class
2 participants