-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F/app serializers #103
F/app serializers #103
Conversation
Assigning to @beporter for review and feedback. |
Signed-off-by: Justin Yost <justin@loadsys.com>
One specific thing comes to mind: Does this work even if the consuming Cake project does not have a It seems like the In other words: It should work exactly like AppController and AppModel. |
Adds path to both the App Serializer Path Also adds path to the Serializers Plugin Path Signed-off-by: Justin Yost <justin@loadsys.com>
Only needs to know about the Serializer object, not the path to the plugin object Signed-off-by: Justin Yost <justin@loadsys.com>
Signed-off-by: Justin Yost <justin@loadsys.com>
@beporter Throwing back for re-review. |
Nice work, this looks like it mirrors the behavior of Cake's core classes (Models, Controllers, Components, etc.) when it comes to using a core 👍 |
Need to run through this PR and verify it internally before merging. |
Signed-off-by: Justin Yost <justin@loadsys.com>
Adds an AppSerializer class and documentation regarding the use of it.
Note there are no breaking changes in this PR, however the documentation is updated to reflect that AppSerializer class will probably be the primary base Serializer object developers will build upon.
Closes #53