New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37 #39

Closed

elboletaire wants to merge 0 commits into loadsys:dev from ciricihq:dev

Contributor

elboletaire commented Nov 9, 2016 •

edited

Fixes #37

I've tried to add a test to check it, but it crashes due to the routes.php file not being loaded properly. Sorry for that.

The problem with the routes was that you were using the dashedRoutes fallback, which was generating urls of this type (extracted from RoutesShell):

| sitemap._controller:index               | /sitemap/:controller                                       | {"action":"index","plugin":"Sitemap"}                                                              |
| sitemap._controller:_action             | /sitemap/:controller/:action/*                             | {"action":"index","plugin":"Sitemap"}

With my changes, the expected route now is /sitemap(.xml)?:

| sitemap.sitemaps:index                  | /sitemap                                                   | {"controller":"Sitemaps","plugin":"Sitemap","action":"index"}                                      |

elboletaire closed this

elboletaire force-pushed the dev branch from 866c0d6 to 8157192 Compare

November 9, 2016 14:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment