Fix xml serialization #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, I just merged a PR that fixes the CS and updates the tests a tad, please rebase this and I can take a look at it. Thanks. |
elboletaire
force-pushed
the
b/xml-serialization
branch
from
60c4e93
to
af0f4d2
Compare
elboletaire
force-pushed
the
b/xml-serialization
branch
from
af0f4d2
to
fcc966c
Compare
|
Done |
|
Thanks for producing this PR @elboletaire. |
|
You're welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, xml serialization is automatically taking a scaffold xml view instead of taking the given xml view by your plugin.
Setting
_serializeto false fixes this issue.