Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make pickX function accessible #615

Closed
wants to merge 1 commit into from
Closed

Conversation

oxc
Copy link
Contributor

@oxc oxc commented May 11, 2024

This is a counter-proposal to #614. Not sure what it's needed for exactly :)

@gausie
Copy link
Contributor

gausie commented May 13, 2024

We could also do this but #614 is designed to improve the API of byClass, byStat etc

@oxc
Copy link
Contributor Author

oxc commented May 13, 2024

As discussed on discord, there is a good use case for having an alternative source, and using source just as the default if not overridden.

@oxc oxc closed this May 13, 2024
@oxc oxc deleted the pickX branch May 23, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants