Remove incrementation flag requirement #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @shaine! Thanks for the contribution! That use-case makes sense, so we can remove the error. Could you squash your commits into one and follow the format of this repo so it'll be included in the changelog? So something like: After that, this'll be good to merge! |
|
I can't believe I didn't think to do that, given the context of this repo (and the fact that you provide contribution guidelines). I'll get that updated, thanks! |
|
Hey @shaine, just pinging on this so we can get it merged and deployed! |
|
Sorry for the delay. Rebased to your suggestion. Thanks! |
|
LGTM! |
|
Just cut |
|
Thanks for the followup, and the great lib! Our team has been finding it very helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the error that requires an incrementation flag type to be set. npm supports a number of other incrementation flags (like prerelease) which could be complicated to add here.
I agree with the general usage advice, and am glad the docs provide those examples. In more complex or legacy build systems, it might be more convenient for a team to manually update the version number before generating the changelog (as opposed to using
npm version). This update provides more flexibility for that use case.