Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable version to be specified #42

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

JasonCust
Copy link
Contributor

test(package): ensure a version can be provided
feat(cli, package): provide option to provide external version value (#35)
docs(README): include documentation for version option

@Valko54
Copy link

Valko54 commented Oct 5, 2018

Nice job !

It's a very good idea for a good CI/CD process. Is it possible to accept this pull request ?

@andremescaline
Copy link

@robinjoseph08 any updates about that functionality?

@JasonCust
Copy link
Contributor Author

JasonCust commented Mar 16, 2020

For anyone who want this functionality, I made a fork a while back that includes it: https://github.com/JasonCust/generate-changelog

@MihaiVoinea
Copy link

This is a great idea for CI/CD! Any updates on this? Any chance to get this merged?

@julianlam
Copy link

@JasonCust Any chance you can publish this onto npm under your namespace, e.g. @JasonCust/generate-changelog?

@julianlam
Copy link

julianlam commented Aug 19, 2020

Hi all,

@julianlam/generate-changelog@1.8.1 has been published to npm, which is a fork of @JasonCust's fork. The only difference is that it uses the semver package to bump versions, so running generate-changelog on a package with a pre-release version (e.g. 1.2.3-beta.1) no longer incorrectly increments the version.

Copy link

@MihaiVoinea MihaiVoinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this get merged, @lob?

@JasonCust
Copy link
Contributor Author

@JasonCust Any chance you can publish this onto npm under your namespace, e.g. @JasonCust/generate-changelog?

@julianlam Apologies for missing your comment! I had contemplated this but what I did was just create a fork that I have been using personally hoping that @lob might merge it at some point. Unfortunately it seems this repo has gone stale so maybe I should finally go that route as I had thought of a few other improvements as well.

@JasonCust
Copy link
Contributor Author

This is the forked repo if anyone is interested: https://github.com/JasonCust/generate-changelog

If I do get around to a writing new version I’ll update this thread.

@julianlam
Copy link

@JasonCust If you do publish to npm, you may as well do a fork under a different name. I'd be happy to help maintain. First thing I'd do is just PR my semver change against your repo 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants