Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github action #179

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Github action #179

merged 1 commit into from
Dec 29, 2021

Conversation

Kilo59
Copy link
Contributor

@Kilo59 Kilo59 commented Dec 10, 2021 •
edited by ShariqT
Loading

TODO

  • Add API key secret
  • Fix tests
  • verify coveralls step
  • add pypy to test matrix
  • remove travis file

@Kilo59 Kilo59 self-assigned this Dec 10, 2021
@Kilo59
Copy link
Contributor Author

Kilo59 commented Dec 17, 2021

To skip failing tests

https://docs.pytest.org/en/6.2.x/skipping.html#xfail-mark-test-functions-as-expected-to-fail

@ShariqT ShariqT force-pushed the gh-actions branch 2 times, most recently from 2d7031c to 755d310 Compare December 20, 2021 23:39
@ShariqT
Copy link
Contributor

ShariqT commented Dec 20, 2021

The coveralls step will take a little more investigation. The Coverall Github Action only takes lcov.info files, but coverage doesn't output anything but json, html or xml. I tried some of the suggestions found in this issue. In the meantime, we can at least have the tests running and circle back in the new year about what to do with coveralls. In the thread there were people suggesting other services that will parse json and xml, so that is something else to consider.

@ShariqT ShariqT marked this pull request as ready for review December 20, 2021 23:55
Kilo59
Kilo59 commented Dec 21, 2021
View reviewed changes
Pipfile Outdated Show resolved Hide resolved
BennyKitchell
BennyKitchell reviewed Dec 21, 2021
View reviewed changes
.github/workflows/build.yaml
@@ -0,0 +1,23 @@
name: Pipenv Coveralls Test

on: ["push", "pull_request"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this push intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a public repo so I don't think the minutes eaten up by it cost Lob anything.

@ShariqT ShariqT merged commit 9382ba6 into master Dec 29, 2021
@ShariqT ShariqT deleted the gh-actions branch December 29, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShariqT ShariqT ShariqT left review comments

@BennyKitchell BennyKitchell BennyKitchell left review comments

@mwj8410 mwj8410 mwj8410 approved these changes

@sudoku-lord sudoku-lord Awaiting requested review from sudoku-lord

Assignees

@ShariqT ShariqT

@Kilo59 Kilo59

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kilo59 @ShariqT @mwj8410 @BennyKitchell