Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage for error cases #96

Closed
mgartner opened this issue Apr 20, 2015 · 5 comments
Closed

Improve coverage for error cases #96

mgartner opened this issue Apr 20, 2015 · 5 comments

Comments

@mgartner
Copy link

https://coveralls.io/files/642057071
@mgartner
Copy link
Author

I'll take a look at this next week, and address coverage confusion.

@robinjoseph08
Copy link
Contributor

It looks like https://coveralls.io/files/642057071#L60 would only be executed if it gets a bad JSON response from the API. Is this something we should be trying to catch?

@pon
Copy link
Contributor

pon commented May 8, 2015

It's fine to catch - just not testable.

@robinjoseph08
Copy link
Contributor

Is there a way to ignore it during coverage?

@mgartner
Copy link
Author

mgartner commented May 8, 2015

Looks like we use simplecov. https://github.com/colszowka/simplecov

looking for a way to ignore now.

@robinjoseph08 robinjoseph08 mentioned this issue Sep 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pon @mgartner @robinjoseph08