-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve coverage for error cases #96
Comments
I'll take a look at this next week, and address coverage confusion. |
It looks like https://coveralls.io/files/642057071#L60 would only be executed if it gets a bad JSON response from the API. Is this something we should be trying to catch? |
It's fine to catch - just not testable. |
Is there a way to ignore it during coverage? |
Looks like we use simplecov. https://github.com/colszowka/simplecov looking for a way to ignore now. |
https://coveralls.io/files/642057071
The text was updated successfully, but these errors were encountered: