Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-raise the original error if error parsing fails #35

Merged
merged 1 commit into from
Jul 24, 2014
Merged

Re-raise the original error if error parsing fails #35

merged 1 commit into from
Jul 24, 2014

Conversation

greysteil
Copy link
Contributor

  • re-raise the original error if error parsing fails
  • DRY up error handling code

@greysteil
Re-raise the original error if error parsing fails
4be1531 
- re-raise the original error if error parsing fails
- DRY up error handling code
@greysteil
Copy link
Contributor Author

Got a JSON::GeneratorError from the Lob gem today because parsing a failed submission (500 on your side? Went through fine on a second attempt).

@greysteil greysteil mentioned this pull request Jul 24, 2014
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.37%) when pulling 4be1531 on greysteil:better-error-handling into 2f7dbe8 on lob:master.

@bsiddiqui
Copy link
Contributor

nice work

bsiddiqui added a commit that referenced this pull request Jul 24, 2014
@bsiddiqui
Merge pull request #35 from greysteil/better-error-handling
38780d6 
Re-raise the original error if error parsing fails
@bsiddiqui bsiddiqui merged commit 38780d6 into lob:master Jul 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greysteil @coveralls @bsiddiqui