Add methods to use semaphore from ISR #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schteve
reviewed
Mar 21, 2023
| @@ -38,6 +38,15 @@ extern "C" { | |||
| pub fn freertos_rs_give_mutex(mutex: FreeRtosQueueHandle) -> FreeRtosBaseType; | |||
| pub fn freertos_rs_give_recursive_mutex(mutex: FreeRtosQueueHandle) -> FreeRtosBaseType; | |||
|
|
|||
| pub fn freertos_rs_take_semaphore_isr( | |||
| semaphore: FreeRtosQueueHandle, | |||
There was a problem hiding this comment.
I see the other semaphore functions take and emit QueueHandle but that looks wrong to me. The underlying type is the same, so it works, but I think it should be FreeRtosSemaphoreHandle. Changing this might be more than you wanted to do here so I'm happy to move that rework to a separate PR.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There already are shim functions for that, but they were not used in Rust library.