Avoid nested if

lobehub · Apr 30, 2024 · 17f136a · 17f136a
1 parent 995c43c
commit 17f136a
Showing 1 changed file with 34 additions and 34 deletions.
diff --git a/src/app/(main)/chat/(desktop)/features/ChatInput/Footer/DragUpload.tsx b/src/app/(main)/chat/(desktop)/features/ChatInput/Footer/DragUpload.tsx
@@ -67,11 +67,11 @@ const allowTextDrag = platform && /Linux|Windows/.test(platform) && getEngine()
 const disallowTextDrag = !allowTextDrag;
 
 const handleDragOver = (e: DragEvent) => {
-  if (e.dataTransfer?.items && e.dataTransfer.items.length > 0) {
-    const isFile = e.dataTransfer.types.includes('Files'); // Webpage image drag
-    if (disallowTextDrag || isFile) {
-      e.preventDefault();
-    }
+  if (!e.dataTransfer?.items || e.dataTransfer.items.length === 0) return;
+
+  const isFile = e.dataTransfer.types.includes('Files');
+  if (disallowTextDrag || isFile) {
+    e.preventDefault();
   }
 };
 
@@ -103,50 +103,50 @@ const DragUpload = memo(() => {
   };
 
   const handleDragEnter = (e: DragEvent) => {
-    if (e.dataTransfer?.items && e.dataTransfer.items.length > 0) {
-      const isFile = e.dataTransfer.types.includes('Files');
-      if (disallowTextDrag || isFile) {
-        dragCounter.current += 1;
-        e.preventDefault();
-        setIsDragging(true);
-      }
+    if (!e.dataTransfer?.items || e.dataTransfer.items.length === 0) return;
+
+    const isFile = e.dataTransfer.types.includes('Files');
+    if (disallowTextDrag || isFile) {
+      dragCounter.current += 1;
+      e.preventDefault();
+      setIsDragging(true);
     }
   };
 
   const handleDragLeave = (e: DragEvent) => {
-    if (e.dataTransfer?.items && e.dataTransfer.items.length > 0) {
-      const isFile = e.dataTransfer.types.includes('Files');
-      if (disallowTextDrag || isFile) {
-        e.preventDefault();
+    if (!e.dataTransfer?.items || e.dataTransfer.items.length === 0) return;
+
+    const isFile = e.dataTransfer.types.includes('Files');
+    if (disallowTextDrag || isFile) {
+      e.preventDefault();
 
-        // reset counter
-        dragCounter.current -= 1;
+      // reset counter
+      dragCounter.current -= 1;
 
-        if (dragCounter.current === 0) {
-          setIsDragging(false);
-        }
+      if (dragCounter.current === 0) {
+        setIsDragging(false);
       }
     }
   };
 
   const handleDrop = async (e: DragEvent) => {
-    if (e.dataTransfer?.items && e.dataTransfer.items.length > 0) {
-      const isFile = e.dataTransfer.types.includes('Files');
-      if (disallowTextDrag || isFile) {
-        e.preventDefault();
+    if (!e.dataTransfer?.items || e.dataTransfer.items.length === 0) return;
+
+    const isFile = e.dataTransfer.types.includes('Files');
+    if (disallowTextDrag || isFile) {
+      e.preventDefault();
 
-        // reset counter
-        dragCounter.current = 0;
+      // reset counter
+      dragCounter.current = 0;
 
-        setIsDragging(false);
+      setIsDragging(false);
 
-        // get filesList
-        // TODO: support folder files upload
-        const files = e.dataTransfer?.files;
+      // get filesList
+      // TODO: support folder files upload
+      const files = e.dataTransfer?.files;
 
-        // upload files
-        uploadImages(files);
-      }
+      // upload files
+      uploadImages(files);
     }
   };