✨ feat: adding Arabic Language Support #1049
Conversation
|
@MEClouds is attempting to deploy a commit to the LobeHub Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for raising your pull request and contributing to our Community |
arvinxx
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1049 +/- ##
=======================================
Coverage 88.31% 88.32%
=======================================
Files 177 177
Lines 8293 8298 +5
Branches 942 942
=======================================
+ Hits 7324 7329 +5
Misses 969 969 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@MEClouds Thanks for your amazing work! I have check your code, it's great! Just need a few improvements:
- There is a FOUC when using Arabic with server side rendering:
the fix method is to add the dir attribute to the html tag:
https://github.com/lobehub/lobe-chat/blob/main/src/app/layout.tsx#L25
const direction = isRtlLang(lng?.value) ? 'rtl' : 'ltr';
return <html lang={lang?.value || DEFAULT_LANG} dir={direction} >- Please use native Arabic display here for consistency.
|
Thank you for your kind words! I'm thrilled to hear that you've reviewed the code and found it great. I appreciate your feedback and I'm ready to implement the suggested improvements. |
|
❤️ Great PR @MEClouds ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
## [Version 0.120.0](v0.119.13...v0.120.0) <sup>Released on **2024-01-15**</sup> #### ✨ Features - **misc**: Adding Arabic Language Support. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Adding Arabic Language Support, closes [#1049](#1049) ([a325ef9](a325ef9)) </details> <div align="right"> [](#readme-top) </div>
|
🎉 This PR is included in version 0.120.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [Version 1.2.0](v1.1.8...v1.2.0) <sup>Released on **2024-01-15**</sup> #### ✨ Features - **misc**: Adding Arabic Language Support. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Adding Arabic Language Support, closes [lobehub#1049](https://github.com/bentwnghk/lobe-chat/issues/1049) ([a325ef9](a325ef9)) </details> <div align="right"> [](#readme-top) </div>
## [Version 0.120.0](lobehub/lobe-chat@v0.119.13...v0.120.0) <sup>Released on **2024-01-15**</sup> #### ✨ Features - **misc**: Adding Arabic Language Support. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Adding Arabic Language Support, closes [#1049](lobehub/lobe-chat#1049) ([a325ef9](lobehub/lobe-chat@a325ef9)) </details> <div align="right"> [](#readme-top) </div>
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
This pull request introduces Arabic language support to the Lobe Chat project, following the guidelines provided in the Add New Locale documentation.
📝 补充信息 | Additional Information
I have added right-to-left (RTL) style changes to enhance the visual presentation for the Arabic language.
Screenshots