Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock @azure/core-rest-pipeline to 1.16.0 #3066

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

BrandonStudio
Copy link
Contributor

@BrandonStudio BrandonStudio commented Jun 28, 2024

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ”จ chore
  • โšก๏ธ perf
  • ๐Ÿ“ docs

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

Lock @azure/core-rest-pipeline to 1.16.0. Workaround for #3037, #3053

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

This is just a workaround. We should switch backend environment to Node


core reason: @azure/openai not make the ege runtime as the official supported runtime: Azure/azure-sdk-for-js#30194 (comment)

need to be fixed at azure side: Azure/azure-sdk-for-js#30194

Copy link

vercel bot commented Jun 28, 2024

@BrandonStudio is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

๐Ÿ‘ @BrandonStudio

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@BrandonStudio BrandonStudio changed the title Main Lock @azure/core-rest-pipeline to 1.16.0 Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 93.43%. Comparing base (b7f4bf6) to head (8822cfc).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3066    +/-   ##
========================================
  Coverage   93.43%   93.43%            
========================================
  Files         382      382            
  Lines       23629    23629            
  Branches     1718     2548   +830     
========================================
  Hits        22077    22077            
  Misses       1552     1552            
Flag Coverage ฮ”
app 93.43% <รธ> (รธ)
server 68.05% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Jun 28, 2024 3:00am

@arvinxx
Copy link
Contributor

arvinxx commented Jun 28, 2024

@BrandonStudio ๆต‹่ฏ•ไธ‹ๆ˜ฏๅฆๅฏ็”จ๏ผŸ

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


@BrandonStudio Is it available for testing?

@BrandonStudio
Copy link
Contributor Author

Tested on GitHub Codespace
Used test button, result OK

@arvinxx arvinxx merged commit f3b29f6 into lobehub:main Jun 28, 2024
6 of 7 checks passed
@lobehubbot
Copy link
Member

โค๏ธ Great PR @BrandonStudio โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request Jun 28, 2024
### [Version&nbsp;1.1.15](v1.1.14...v1.1.15)
<sup>Released on **2024-06-28**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Pin `@azure/core-rest-pipeline@1.16.0` to fix azure openai issue.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Pin `@azure/core-rest-pipeline@1.16.0` to fix azure openai issue, closes [#3066](#3066) ([f3b29f6](f3b29f6))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.1.15 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jun 28, 2024
### [Version&nbsp;1.44.10](v1.44.9...v1.44.10)
<sup>Released on **2024-06-28**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Pin `@azure/core-rest-pipeline@1.16.0` to fix azure openai issue.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Pin `@azure/core-rest-pipeline@1.16.0` to fix azure openai issue, closes [lobehub#3066](https://github.com/bentwnghk/lobe-chat/issues/3066) ([f3b29f6](f3b29f6))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@BrandonStudio
Copy link
Contributor Author

@arvinxx ไน‹ๅ‰ไธๆ˜ฏdocker้ƒจ็ฝฒไนŸ็”จไธไบ†ๅ—๏ผŸdockerๅŒ…้‡Œ้ขไนŸๆ˜ฏedge runtimeๅ—๏ผŸ

@arvinxx
Copy link
Contributor

arvinxx commented Jul 1, 2024

@BrandonStudio ๆ˜ฏ็š„ใ€‚ๅฆ‚ๆžœไปฃ็ ้‡Œ้…็ฝฎไบ† export const runtime = 'edge' , ้‚ฃไนˆ nextjs ไผšๅŸบไบŽ edge-runtime ๅŒ…ๅœจ node ไธ‹ๆจกๆ‹Ÿๅ‡บๆฅไธ€ไธช edge ่ฟ่กŒๆ—ถ

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


@BrandonStudio Yes. If export const runtime = 'edge' is configured in the code, then nextjs will simulate an edge runtime under node based on the edge-runtime package

Mingholy pushed a commit to Mingholy/lobe-chat that referenced this pull request Jul 1, 2024
Mingholy pushed a commit to Mingholy/lobe-chat that referenced this pull request Jul 1, 2024
### [Version&nbsp;1.1.15](lobehub/lobe-chat@v1.1.14...v1.1.15)
<sup>Released on **2024-06-28**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Pin `@azure/core-rest-pipeline@1.16.0` to fix azure openai issue.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Pin `@azure/core-rest-pipeline@1.16.0` to fix azure openai issue, closes [lobehub#3066](lobehub#3066) ([f3b29f6](lobehub@f3b29f6))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@BrandonStudio
Copy link
Contributor Author

@arvinxx dockerๅŒ…้‡Œๆ˜ฏไธๆ˜ฏๆฒกๆœ‰ๅฟ…่ฆ็”จedgeๅ‘€๏ผŸๆˆ‘ไปฌ่ฆไธ่ฆ่€ƒ่™‘ๅœจๆ‰“ๅŒ…docker็š„ๆ—ถๅ€™ๅ–ๆถˆedge่ฟ่กŒๆ—ถ๏ผŒๅ…จ้ƒจๅœจnode้‡Œ่ฟ่กŒ๏ผŸ

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


@arvinxx Is it unnecessary to use edge in the docker package? Should we consider canceling the edge runtime when packaging docker and running everything in node?

@arvinxx
Copy link
Contributor

arvinxx commented Jul 1, 2024

@BrandonStudio ไปฅๅ‰่ฏ•่ฟ‡๏ผŒ export const runtime = 'edge' ่ฟ™้กน้…็ฝฎไธๆ”ฏๆŒๆกไปถๅˆคๆ–ญ๏ผŒไธ็„ถ PROXY ๆ”ฏๆŒๅฐฑๅพˆ็ฎ€ๅ•ไบ†ใ€‚

@BrandonStudio
Copy link
Contributor Author

@arvinxx ๅœจ dockerfile ้‡Œๆ‰“ๅŒ…ไน‹ๅ‰ๅŠ ไธ€ๆญฅๆŠŠๆ‰€ๆœ‰ๆ–‡ไปถ็š„export edge้ƒฝๅŽปๆŽ‰๏ผŒ่ฟ™ๆ ทๅˆ็†ๅ—๏ผŸ

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


@arvinxx Add a step to remove the export edges of all files in the dockerfile before packaging. Is this reasonable?

@arvinxx
Copy link
Contributor

arvinxx commented Jul 10, 2024

@BrandonStudio ็†่ฎบไธŠๅบ”่ฏฅๅฏไปฅ

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


@BrandonStudio In theory it should be possible

ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
### [Version&nbsp;1.1.15](lobehub/lobe-chat@v1.1.14...v1.1.15)
<sup>Released on **2024-06-28**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Pin `@azure/core-rest-pipeline@1.16.0` to fix azure openai issue.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Pin `@azure/core-rest-pipeline@1.16.0` to fix azure openai issue, closes [lobehub#3066](lobehub#3066) ([f3b29f6](lobehub@f3b29f6))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants