Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upvote buttons on mobile awfully small #642

Open
faebser opened this issue Feb 17, 2019 · 6 comments
Open

Upvote buttons on mobile awfully small #642

faebser opened this issue Feb 17, 2019 · 6 comments

Comments

@faebser
Copy link

faebser commented Feb 17, 2019

Sometimes it takes me a three or four tries to successfully upvote a post on mobile. I looked at the html/css and the button is a small 18x18 pixel arrow made with border-radius.

IMHO it would make sense to have the upvote button to be whole width between the border on the left and the headline on the right. To achieve this I would like to enlarge the existing a element and add a child element that is going to hold the arrow. This provides a bigger clickable surface while maintaining the same look.

@pushcx pushcx added the bug label Feb 17, 2019
@pushcx
Copy link
Member

pushcx commented Feb 17, 2019

Sounds good to me. Are the comment arrows similarly hard to tap?

@faebser
Copy link
Author

faebser commented Feb 18, 2019

They are slightly easier to hit, maybe because there is more white space around them. If you want I can also extend them the same way.

Are there any tests for the frontend?

@pushcx
Copy link
Member

pushcx commented Feb 19, 2019

If the style carries over, yeah, let's increase their target size as well.

There are no tests for the frontend.

@faebser
Copy link
Author

faebser commented Feb 19, 2019

Actually let me backtrack on the following quote

They are slightly easier to hit

They are really easier to hit. Please let me look into that.

@magikid
Copy link
Contributor

magikid commented Oct 16, 2019

@faebser Are you still looking into this?

@faebser
Copy link
Author

faebser commented Oct 29, 2019

hi @magikid, yes I will fix this in the following days

faebser pushed a commit to faebser/lobsters that referenced this issue Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants