Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added gem prosopite #1260

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Added gem prosopite #1260

merged 6 commits into from
Mar 4, 2024

Conversation

mikalai-yankouski
Copy link
Contributor

@mikalai-yankouski @pushcx
change log path
cb5a66f 
Co-authored-by: Peter Bhat Harkins <pushcx@users.noreply.github.com>
pushcx
pushcx requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@pushcx pushcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one small change to minimize how much is ignored, and I'll merge with that.

This is really nice to have, thanks for working through the setup.

app/models/story.rb Show resolved Hide resolved
@pushcx
Copy link
Member

pushcx commented Mar 1, 2024

Oh, the build is failing because the new initializer doesn't start with # typed: false (see the others for examples), so please add that line.

mikalai-yankouski and others added 2 commits March 4, 2024 10:37
@mikalai-yankouski @pushcx
Update app/models/story.rb
7636ccc 
Co-authored-by: Peter Bhat Harkins <pushcx@users.noreply.github.com>
@mikalai-yankouski
review fixes
ca1f680
@mikalai-yankouski
Copy link
Contributor Author

There's one small change to minimize how much is ignored, and I'll merge with that.

This is really nice to have, thanks for working through the setup.

you are welcome

@pushcx pushcx merged commit 4bcf0b4 into lobsters:master Mar 4, 2024
1 check passed
@pushcx
Copy link
Member

pushcx commented Mar 4, 2024

Thanks for working through these reviews, I'm very happy to merge this for better protection against perf regressions.

@pushcx pushcx mentioned this pull request Mar 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pushcx pushcx Awaiting requested review from pushcx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikalai-yankouski @pushcx