Forces encoding to utf-8 when fetching url titles [Resolves #648] #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briankung
changed the title
|
Phew, what a corner case to run down, thanks for the deep dive and clear test. (You know, if you like obscure encoding errors, #328 is a finely-aged sample of the genre...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it moderately difficult to write a test case for this, since it seems like all the tests I wrote seemed to assume UTF-8 encoding and passed the \xe2\x80\x99 apostrophe through just fine.Regression test added.Manual testing confirms that it works for the URL in #648 (https://www.codewithjason.com/sometimes-better-tests-hit-real-api/)
I can't locate Abdullah Samman, the last person to touch this line in 0e198cb, on GitHub, or I'd tag them as a reviewer.
Set to draft PR awaiting feedback on testing! I could spend a bit longer working on getting a test case written or we could just merge it.