Update fake_data to create test Categories and pass those in to new Tags #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new tags when created. Does not use find_and_create_by! for new Tags since that could attempt to create another tag with the same name if the random Category is different. Update fake_data to use the newer Faker::Lorem syntax, specifying the parameter name in .sentences() and .paragraphs().
|
Thanks for fixing this, and even updating our deprecated style. |
pushcx
pushed a commit
that referenced
this pull request
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #914 by creating test Categories during
rails fake_dataand pulling those randomly in to the creation of new Tags.Note: This does not use
find_and_create_by!for Tags since that could attempt to create another tag with the same name if the random Category is different. Instead it checks for an existing tag (regardless of Category) and, if that is not found, then tries to create a new tag.This also updates
rails fake_datato use the newer Faker::Lorem syntax, specifying the parameter name in .sentences() and .paragraphs(). This is a follow-on from the work in #881.