Do not follow Location header when followlocation option is set to false #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimameshcharakou
force-pushed
the
follow-location
branch
from
89c312b
to
3cc04cb
Compare
dimameshcharakou
force-pushed
the
follow-location
branch
from
3cc04cb
to
be7028d
Compare
christianarevalo
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We already use
followlocationoption inlhcwhen we want to follow the redirects: https://github.com/local-ch/lhc/blob/master/README.md#follow-redirectsThis PR adds the changes that
lhstakes into account this option when it's going to follow theLocationheader in the response.Only minor release since the default behaviour hasn't changed.