Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localStorage driver clear() does not respect store name (namespace) #246

Closed
bitinn opened this issue Sep 12, 2014 · 1 comment · Fixed by #265
Closed

localStorage driver clear() does not respect store name (namespace) #246

bitinn opened this issue Sep 12, 2014 · 1 comment · Fixed by #265

Comments

@bitinn
Copy link

bitinn commented Sep 12, 2014

since we are prefixing the localStorage key to get it working with storeName (sort of namespacing), using localStorage.clear() seem undesirable, we should probably enumerate keys and match prefix before deleting them.

@tofumatt
Copy link
Member

Good point, this is also something we should have a test for but don't. Good catch!

tofumatt (Sent from mobile)

On September 12, 2014 4:01:28 AM EDT, David Frank notifications@github.com wrote:

since we are prefixing the localStorage key to get it working with
storeName (sort of namespacing), using localStorage.clear() seem
undesirable both, we should probably enumerate keys and match prefix.


Reply to this email directly or view it on GitHub:
#246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants