Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes driverSupport #284

Merged
merged 1 commit into from
Oct 22, 2014
Merged

fixes driverSupport #284

merged 1 commit into from
Oct 22, 2014

Conversation

Evgenus
Copy link
Contributor

@Evgenus Evgenus commented Oct 22, 2014

In IE falsely reports IndexedDB as unavailable. Because in IE typeof self.IDBKeyRange === 'object'

In IE falsely reports IndexedDB as unavailable. Because in IE `typeof self.IDBKeyRange === 'object'`
@tofumatt
Copy link
Member

Hmm, @nolanlawson, might want to note this for pouch :-)

tofumatt added a commit that referenced this pull request Oct 22, 2014
@tofumatt tofumatt merged commit 61825f7 into localForage:master Oct 22, 2014
@nolanlawson
Copy link
Contributor

That's bizarre; all our tests are still passing in IE10. Was it in IE11 that you saw this @Evgenus ?

@nolanlawson
Copy link
Contributor

Oh wait, we just check the truthiness of IDBKeyRange, which is why this was working. Sorry for giving you a shoddy commit @tofumatt >_<

@tofumatt
Copy link
Member

No worries, I’m gonna look at this deeper this afternoon I think ^_^

  • tofumatt

On October 22, 2014 at 13:00:51, Nolan Lawson (notifications@github.com) wrote:

Oh wait, we just check the truthiness of IDBKeyRange, which is why this was working. Sorry for giving you a shoddy commit @tofumatt >_<


Reply to this email directly or view it on GitHub.

@Evgenus
Copy link
Contributor Author

Evgenus commented Oct 22, 2014

Was it in IE11 that you saw this @Evgenus ?

Yes. But I guess it is not important.

@Evgenus Evgenus deleted the patch-1 branch October 22, 2014 21:58
@Evgenus
Copy link
Contributor Author

Evgenus commented Oct 22, 2014

Will you publish this soon? It blocks IE support in my project.

@tofumatt
Copy link
Member

Published version 1.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants