fix(localStorageDriver): fix odd length buffer serialization #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got some code from websql driver. |
|
Just added a commit that abstracts the serialization code to a separate file and closes #114. |
…put buffer for `Uint16Array` should have even length!!
thgreasi
force-pushed
the
odd-length-binary-fix
branch
from
d896220
to
62b1483
Compare
|
@tofumatt Just did an extra rebase, hope it helps. |
|
Whoa, sweet! 👍 Took a quick look and it seems awesome. I'll look over once more but I think this is good to merge. I'll get this in before I check on the batching PRs. |
tofumatt
added a commit
that referenced
this pull request
Dec 27, 2014
fix(localStorageDriver): fix odd length buffer serialization
|
So awesome, thanks so much for this one! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebases and resolves #285.
Closes #114.